3 ms·
In this case, he's made a full class when all he needed was a module to provide a namespace. In the grand scheme of things that's not a huge mis-step, but it co
by regularfry 15y ago
In this case, he's made a full class when all he needed was a module to provide a namespace. In the grand scheme of things that's not a huge mis-step, but it communicates the wrong idea to the reader, in my mind.
- tptacek 15y agoLater he makes the same mistake, and then proceeds to refactor the function into private helper methods with a public interface. (I'm assuming/hoping he's finding the feedback productive.)