6 ms·
This is their process. Very hard to argue these are all mistakes: ippsample (Apache -> MIT) https://github.com/microsoft/ippsample/commit/938bff17c7286823c4bb5
by throwaway277432 5y ago
This is their process. Very hard to argue these are all mistakes:
ippsample (Apache -> MIT)
https://github.com/microsoft/ippsample/commit/938bff17c7286823c4bb5e5097313f5ef90a02e6 https://github.com/microsoft/ippsample/commit/938bff17c72868...
huggingface-transformers (Apache -> MIT):
https://github.com/microsoft/huggingface-transformers/commit/1d5d50bad9afb6ffafb71a1073d9e496996188a5 https://github.com/microsoft/huggingface-transformers/commit...
health-cards-tests (MIT changed)
https://github.com/microsoft/health-cards-tests/commit/5649b54a56e1f62da3c7dfe489579dc4cfd1fa8f https://github.com/microsoft/health-cards-tests/commit/5649b...
CUPS (Apache -> MIT)
https://github.com/microsoft/cups/commit/ad69bcc78bdea3fea3f09fe56674daea821bb407 https://github.com/microsoft/cups/commit/ad69bcc78bdea3fea3f...
Credit to this reddit comment: https://www.reddit.com/r/opensource/comments/roa9xz/comment/hpx67x2/ https://www.reddit.com/r/opensource/comments/roa9xz/comment/...
- throwaway277432 5y ago(deleted)
- Tyriar 5y agoMS acquired that extension, Don works at MS now.
- throwaway277432 5y agoYou're right. Saw the reviewer on that PR but you were too quick and I couldn't delete my comment anymore.
- Tyriar 5y agoMS dev here. Thanks for calling this out. I contacted the GH@MS admins to look into this and to consider adding some safeguards to the tooling so this doesn't happen in the future.
- ordiel 5y agoAnd so ther revert the ones done in the past I hope...
- rStar 5y ago
- deleted 5y ago[deleted]
- michaelmrose 5y agoHow is it remotely possible to not understand you cannot automatically overwrite a license file with your own. If you yourself were creating such automation wouldn't that be one of the first and most obvious things you would think of?
- mlyle 5y agoIf you think of the use case of forks, sure. If you think of employees creating new repos in the org--- smash the correct LICENSE in there ASAP. The problem is that forking a different repo into the org triggers the logic of a "new repository".
- wise_young_man 5y agoA simple solution prior to writing to a file in this case is to check if it already exists. It shouldn’t matter what triggers this bot if it’s programmed safe and idempotent.
- dpark 5y agoSo your simple solution is to not have the bug. Wish I’d thought of this for all the bugs I’ve ever shipped. Disclosure: Microsoft employee who sometimes writes bugs.
- verst 5y agoThis is a bot that is supposed to configure the right license when employees start a new repo in the Microsoft GitHub org. It seems the automation is also triggered when Repos are forked into the Microsoft GitHub org which isn't correct behavior. This isn't a deliberate action. If it were plenty of employees (myself included) would be outraged. I assume it's a bug in the bot - an edge case that was not considered. It is very rare to fork something into the Microsoft GitHub org after all. I'll pass it along to some people I know.
- chris_wot 5y agoHave you considered that the reason for the outrage is because people don't actually trust Microsoft to do the right thing? I can see this is a mistake, but surely the litany of awful business practices by Microsoft in the past precedes it?
- verst 5y agoI didn't say anything about the outrage of others. I said a deliberate license change would be unacceptable to employees. I'm no official representative of Microsoft...
- rStar 5y ago
- chris_wot 5y agoSorry, I didn't mean to imply you were. But no offense, so what if it isn't acceptable to employees? The decisions by Microsoft are made by the management of the company. As an example of another company with severe credibility problems, I'm sure there are plenty of employees at Facebook who don't like working there now, but they are still there. And still implementing the policies and directions of management.
- throwaway277432 5y agoThank you. So these are in fact all mistakes. I looked at some of the other forked repos (95 out of 4.5K repos) and all the human commits from MS I saw seem to care about getting the licenses right. So it really is just a broken bot. I hope the bot can be fixed soon and I'm going to put my figurative pitchfork down now.
- phendrenad2 5y agoWrong. The more links, the easier it is to argue that it's a mistake. Automation is hard, you know? Especially if no one noticed these and called them out on it until now.
- fivea 5y ago> Wrong. The more links, the easier it is to argue that it's a mistake. Automation is hard, you know? Is it wrong though? I mean, if Microsoft's reiterated pattern of license switches is automated, wouldn't this also mean that the error would be easily detected based on public feedback alone? And given this was not the first or second or third separate and independent occurrence of this pattern, if this was a honest mistake then wouldn't this already be addressed in any of the multiple past shout-out?
- nomel 5y ago> wouldn't this also mean that the error would be easily detected based on public feedback alone Please see the entire public feedback you’re a part of right now.
- fivea 5y agoThanks for the call out. Here's a helpful link to the announcement. https://news.ycombinator.com/item?id=29685628 https://news.ycombinator.com/item?id=29685628