2 ms·
> On top of that, do you review git commit message in code review? Do you aks people to improve descriptions, typos and language in commit messages? Absolutely
by b3morales 5y ago
> On top of that, do you review git commit message in code review? Do you aks people to improve descriptions, typos and language in commit messages?
Absolutely I do. The commit message is part of the commit just like the code; why would it be excluded from review? The number of times that a good commit message has helped me when dealing with a bug, and that a poor one has stymied me, have firmly convinced me that they are just as important as any other project documentation. They should be clear and informative, and I ask for those aspects to be improved when needed.