5 ms·

Multiple of your “senior” developers didn’t catch this in a “senior” developer’s PR? Have they ever read any of the IO documentation, since this is pointed out

by eska 5y ago

Multiple of your “senior” developers didn’t catch this in a “senior” developer’s PR? Have they ever read any of the IO documentation, since this is pointed out literally everywhere in the docs? https://doc.rust-lang.org/std/fs/struct.File.html https://doc.rust-lang.org/std/fs/struct.File.html https://doc.rust-lang.org/std/io/trait.Read.html https://doc.rust-lang.org/std/io/trait.Read.html

maccard 5y ago
You don't even need to be familiar with rust to know this - it's a feature of pretty much language. That said, I can guarantee rate I have missed such issues in my code both as the writer and the reviewer. Saying "it's in the documentation" doesn't mean it's inexcusable to make 5he mistake.
DangitBobby 5y ago
Look at this guy over here "making mistakes" and "missing things in code review." What a fraud. Btw, pointing to documentation and saying "see, it's documented!" Every time something has lame or broken or unexpected default behavior doesn't make it any less lame or broken or unexpected. Once you feel like you know how to use something, you aren't always checking the docs to get a refresher on the caveats. So tone it down with the accusations and the "helpful" links, everyone else has access to the same Google you do.
kilburn 5y ago
Everybody makes mistakes. Being senior doesn't make you infallible, or otherwise we wouldn't spend huge amounts of resources building tools that are essentially mistake-catchers: smarter type systems, linters, static analyzers and so on. Also, senior people are more likely to make the kind of mistake explained in the article than less experienced developers. This is because: - They are more focused on the "big picture" (algorithm correctness, general approach, system architecture, etc.) than on minute details. - They tend to read less documentation because they don't need to reach for it so often. - They have learned that a mistake such as this one can be easily corrected, and hence dedicate their attention to more important matters (avoiding data corruption for instance).

by eska 5y ago

maccard 5y ago

You don't even need to be familiar with rust to know this - it's a feature of pretty much language. That said, I can guarantee rate I have missed such issues in my code both as the writer and the reviewer. Saying "it's in the documentation" doesn't mean it's inexcusable to make 5he mistake.

DangitBobby 5y ago

Look at this guy over here "making mistakes" and "missing things in code review." What a fraud. Btw, pointing to documentation and saying "see, it's documented!" Every time something has lame or broken or unexpected default behavior doesn't make it any less lame or broken or unexpected. Once you feel like you know how to use something, you aren't always checking the docs to get a refresher on the caveats. So tone it down with the accusations and the "helpful" links, everyone else has access to the same Google you do.

kilburn 5y ago

Everybody makes mistakes. Being senior doesn't make you infallible, or otherwise we wouldn't spend huge amounts of resources building tools that are essentially mistake-catchers: smarter type systems, linters, static analyzers and so on. Also, senior people are more likely to make the kind of mistake explained in the article than less experienced developers. This is because: - They are more focused on the "big picture" (algorithm correctness, general approach, system architecture, etc.) than on minute details. - They tend to read less documentation because they don't need to reach for it so often. - They have learned that a mistake such as this one can be easily corrected, and hence dedicate their attention to more important matters (avoiding data corruption for instance).