3 ms·
PullRequest actually reviews the reviewers (I actually became a better reviewer via this). 'LGTM' is considered a bad practise, and I've been pulled up on this
by nathanielarmer 5y ago
PullRequest actually reviews the reviewers (I actually became a better reviewer via this).
'LGTM' is considered a bad practise, and I've been pulled up on this several times. Instead, we're trained to take more time, go deeper, and be very clear about what the changes do, and how well they are written even on relatively trivial changes.