3 ms·
The best code reviews are ones that leverage experience from the reviewer to stop logic errors. Your code may well compile and the tests you concocted may pass
by gorgoiler 5y ago
The best code reviews are ones that leverage experience from the reviewer to stop logic errors. Your code may well compile and the tests you concocted may pass but that doesn’t mean your code should ship. Without a second pair of experienced eyes looking at your crap, how are you to know that:
- (general experience with modelling) what you felt should be a single class would be better if it were factored into two classes; and
- (specific experience with this particular codebase) the second of those classes already exists in the codebase and can be found in com.clown.util?
The former can be helpful but it’s just noise compared to the value of the latter.
How does this service avoid being just a human powered style linter?