4 ms·

LOL. This will become in less than 1 month a "LGTM" feast. 3rd world countries developers (organizing themselves in groups to pass the intro test from the websi

LOL. This will become in less than 1 month a "LGTM" feast. 3rd world countries developers (organizing themselves in groups to pass the intro test from the website) giving green lights to random people around the world for peanuts. This is a clever business model if you ask me. Let's be clear for a second. Nobody, not event the legendary 10x developers can review properly code without context or everything mentioned here: https://news.ycombinator.com/item?id=29624787 https://news.ycombinator.com/item?id=29624787 If we want our code to be approved by random people doing it only for money, this will work for sure, but it's not how it works in the real world.

ivanche 5y ago
It seems they don't accept any reviewer outside US and Canada, let alone 3rd world countries. https://www.pullrequest.com/faq/ https://www.pullrequest.com/faq/
- napolux 5y ago
  Thanks, but that's not enough :)
  - ivanche 5y ago
    As an outsider, I can't say anything more. I know that US/Canadian developers are in no way guarantee that LGTM feast won't happen but that's PullRequest's policy.
dhimes 5y ago
Could you clarify what you mean by "LGTM?" Just people saying, "looks good to me" and doing crappy reviews, or is there some LGTM "thing" out there that everybody will use? Or something else?
- MajorBee 5y ago
  There is a meme out there in the wild (or at least, I think there is a meme) that many reviewers would simply approve PRs blindly leaving a LGTM (looks good to me) comment when their internal monologue is closer to "...I have no idea what's going on here and I'm too afraid to ask at this point". I suppose it could also be sheer laziness of not wanting to parse many lines of new code, especially if you're in a situation where you don't have a 100% tight understanding of the codebase (as I have been in many a times).
  - dhimes 5y ago
    Thanks for the great explanation.
nathanielarmer 5y ago
PullRequest actually reviews the reviewers (I actually became a better reviewer via this). 'LGTM' is considered a bad practise, and I've been pulled up on this several times. Instead, we're trained to take more time, go deeper, and be very clear about what the changes do, and how well they are written even on relatively trivial changes.

ivanche 5y ago

It seems they don't accept any reviewer outside US and Canada, let alone 3rd world countries. https://www.pullrequest.com/faq/ https://www.pullrequest.com/faq/

napolux 5y ago
Thanks, but that's not enough :)
- ivanche 5y ago
  As an outsider, I can't say anything more. I know that US/Canadian developers are in no way guarantee that LGTM feast won't happen but that's PullRequest's policy.

dhimes 5y ago

Could you clarify what you mean by "LGTM?" Just people saying, "looks good to me" and doing crappy reviews, or is there some LGTM "thing" out there that everybody will use? Or something else?

MajorBee 5y ago
There is a meme out there in the wild (or at least, I think there is a meme) that many reviewers would simply approve PRs blindly leaving a LGTM (looks good to me) comment when their internal monologue is closer to "...I have no idea what's going on here and I'm too afraid to ask at this point". I suppose it could also be sheer laziness of not wanting to parse many lines of new code, especially if you're in a situation where you don't have a 100% tight understanding of the codebase (as I have been in many a times).
- dhimes 5y ago
  Thanks for the great explanation.

nathanielarmer 5y ago

PullRequest actually reviews the reviewers (I actually became a better reviewer via this). 'LGTM' is considered a bad practise, and I've been pulled up on this several times. Instead, we're trained to take more time, go deeper, and be very clear about what the changes do, and how well they are written even on relatively trivial changes.