3 ms·
I often approve a PR with the comment "Approved with comments". In other words, I didn't notice any bugs but I have some suggestions. I'll let you decide if yo
by Osiris 5y ago
I often approve a PR with the comment "Approved with comments".
In other words, I didn't notice any bugs but I have some suggestions. I'll let you decide if you want to make the changes or not.
- aredplug 5y ago+1. The job of reviewer on shared codebases is advisory, not as a gatekeeper. If people choose to ignore comments, then that's a behavioral issue worth escalating.
- un_montagnard 5y agoI've been in teams where those comments are never addressed because the pressure is on "push something that roughly solves the task so you can show something during demo".