4 ms·
Yes, there are! Familiar with this approach, pretty common with greenfield development. After causing a few outages and issues that you have to hear about, one
by zebraflask 5y ago
Yes, there are! Familiar with this approach, pretty common with greenfield development.
After causing a few outages and issues that you have to hear about, one learns fairly quickly not to write code that needs endless PR reviews.
- GuestHNUser 5y agoI'm curious to know how does your team avoid shooting itself in the foot with unreviewed code? As in, is there some process that keeps unmaintainable elements from sneaking in?
- zebraflask 5y agoTrust people to know what they're doing? A lot of PR reviews tend to devolve into almost anything but solving the issue at hand.
- GuestHNUser 5y agoFair enough. My experience with reviews has been they are quick quality checks, and at least for teams I have been on, were beneficial. I can see how they could become more of a ritual process than a beneficial one though, especially after seeing some other comments in the thread.
- tetraca 5y agoSurprising. We do a PR and review for nearly every block of work we commit. Most pass without comment. The ones that have comments usually have good suggestions, or actually catch an error.