4 ms·
Perhaps not objectively, but PRs will often be reviewed during performance review season. So seeing someone at 10x less than someone else is a major red flag, a
by ztratar 5y ago
Perhaps not objectively, but PRs will often be reviewed during performance review season. So seeing someone at 10x less than someone else is a major red flag, as long as the quality of PRs is roughly equal.
- pdimitar 5y agoI get where you are coming from but I still disagree that we should try and game the system like that. Instead our peers and CTOs should grow the "realism" brain lobe. This hits even closer home to me because I am about to get evaluated this Monday and my PR performance has been pretty sub-par in the last 3-4 weeks -- I've been put in a project that has been abandoned for like 3 years and only recently picked up again and 90% of what I do is documenting and taking notes and creating GitHub issues; coding is sadly still a low priority activity because there's still chaos. But you know what? I don't care anymore. Let them fire me if they use broken metrics. I am doing my work very diligently and I am making sure the project will be in a better shape after me. If they can't appreciate that then I am not bothered by such people viewing me negatively. They are in the wrong, not me.
- khazhoux 5y agoLOC is just one within many signals your manager and organization should use in their review. If you have low LOC because the project was in chaos, or was still being designed and organized, etc... those would all be fine justifications to me as a manager. In fact, those would be problems for me to solve -- to make sure you are in an environment where you are able to be productive. If, on the other hand, you were on a "smooth sailing" project, and didn't have any code delivered in the last month, that would be a red flag to me, which we would need to talk about.
- pdimitar 5y agoI agree with that, yep.