3 ms·
Adding a simple endpoint to an existing API somehow ended up being a 3-day back and forth in my latest GitHub PR. Worst part is that I knew beforehand that was
by floydian10 5y ago
Adding a simple endpoint to an existing API somehow ended up being a 3-day back and forth in my latest GitHub PR. Worst part is that I knew beforehand that was going to be the case, since it happens all the time.
Can't se myself lasting long here.
- SPascareli13 5y agoBut what exactly was the problem here? That the PR took 3 days? The back and forth comments? That you needed to make a PR in the first place? Because any of this things seem pretty natural to me, specially if you are a new dev in the team and are not familiar with the style they use. But there may be some details missing that will explain the situation.
- danjac 5y agoOne thing that can reduce the PR back-and-forth is to use linters in pre-commit hooks and/or pipelines. For example, if you are using Python then run flake8/black etc automatically on the committed code so you don't end up with bikeshedding over stupid things like line length and bracketing style. This can be enhanced by automated services such as Sonarcloud to catch potential security issues, code repetition and so on.