2 ms·
I've looked at the https://github.com/chiselstrike/chiselstore/blob/main/proto/proto.proto https://github.com/chiselstrike/chiselstore/blob/main/proto/... - and
by malkia 5y ago
I've looked at the https://github.com/chiselstrike/chiselstore/blob/main/proto/proto.proto https://github.com/chiselstrike/chiselstore/blob/main/proto/... - and calling the service "RPC" is not great if this is going to be bundled with other gRPC services - why not call it "chiselStore" or something more concrete?
on a 2nd note, each method should have it's own Request Response, and ideally they should be suffixed same way. Returning same proto for multiple methods might break future compatibility - e.g. what if AppendEntries needs to return somehing else than Void? - ideally you make it from the start to return an empty AppendEntriesResponse, and then you can extend that proto.
https://developers.google.com/protocol-buffers/docs/proto3#updating https://developers.google.com/protocol-buffers/docs/proto3#u...
(edit again, also the package should not be called just "proto")
- returnfalse 5y agoThey can replace Void with AppendEntriesResponse anytime they want and that won't break anything since the change is wire compatible.
- malkia 5y agoDidn't know that! (Good to know, and thanks!)