2 ms·
I don't want to sound like a troll... but you're better off re-writing the whole thing... I mean look at it. https://github.com/russellbeattie/plusfeed/blob/ma
by igorgue 15y ago
I don't want to sound like a troll... but you're better off re-writing the whole thing... I mean look at it.
https://github.com/russellbeattie/plusfeed/blob/master/plusfeed.py https://github.com/russellbeattie/plusfeed/blob/master/plusf...
Global variables galore, tabs no spaces, no documentation, compares to empty not just once but multiple times, pokemon style exception handling (you gotta catch them all!), 'is not None' lol, type checking instead of duck typing... Just to name a few.
14 pople forked it already, I hope those are Github bots.
- humbledrone 15y agoYou realize that you're looking at a 399 line script, right? A couple of globals are perfectly reasonable at that scale. Also note that checking for "x is not None" is the recommended, idiomatic Python style (see http://www.python.org/dev/peps/pep-0008/ http://www.python.org/dev/peps/pep-0008/ for reference). More importantly, the script works, and was apparently used by quite a few people. Rewriting something that is already known to work, just because you don't like its style, is generally a bad idea.
- dev360 15y agoThis code is a complete abomination, why would you stick your neck out and defend it? What igorgue is saying is, even if somebody gave me this code, I wouldn't take it, and I concur.