5 ms·
So it doesn't work for cases where it shouldn't work. And it errors out but doesn't do anything stupid I don't see the problem for something that was just rele
by raverbashing 5y ago
So it doesn't work for cases where it shouldn't work. And it errors out but doesn't do anything stupid
I don't see the problem for something that was just released as a very preliminary version
(Though I don't know where cp is getting "PermissionDenied" from)
- masklinn 5y ago> I don't see the problem for something that was just released as a very preliminary version Fwiw the project os half a decade old. > (Though I don't know where cp is getting "PermissionDenied" from) Have not looked at the problematic code but e.g. copy_file_range(2) says > EPERM fd_out refers to an immutable file.
- db48x 5y agoWhile that is a good point, it is quite unsightly to panic from unwrapping. Instead it should propagate that error back to the top level where a nicer error message can be generated.
- megous 5y agoMore importantly cp should continue copying other inputs even if one of the source files fails to be readable. Handling errors by panic doesn't suggest that will be the case.
- db48x 5y agoI don’t know if that is _more_ important, but I agree that it is also important :) The reason I say this is that while users will expect this behavior, doing it well (so that it can be parallelized, for example) requires careful thinking about how errors should flow, how lines are printed to stdout, etc.