3 ms·
Pointing out back-tics got me worst - adding those or changing it take less time than making a comment on PR for it. Especially pointing out each place ... revi
by ozim 5y ago
Pointing out back-tics got me worst - adding those or changing it take less time than making a comment on PR for it. Especially pointing out each place ... reviewer could spend his time on much more interesting things.
- nyanpasu64 5y agoIf an upstream maintainer prioritizes a clean commit log in pull requests, to enable merge-commits (like I do), then if the maintainer wants to fix formatting, they have to amend commits by the PR author and force-push to the PR author's branch. I'm not sure if "Allow edits by maintainers" allows force-pushing or not, and I don't know if it's considered bad manners to force-push to a feature branch you don't own, in someone else's repository.