3 ms·
Interesting idea, although it would be nice if Github optionally fixed spelling mistakes for you. Pull requests just for spelling errors have got to be annoyin
by jrockway 15y ago
Interesting idea, although it would be nice if Github optionally fixed spelling mistakes for you. Pull requests just for spelling errors have got to be annoying. (I just run flyspell in Emacs, so I never make spelling mistakes. Accept when I use the wrong word.)
The code is also pretty interesting. It's old-style Perl with indirect method calls, bareword filehandles, no "use strict", and so on... but then it uses modules that use Moose and MooseX::Traits. So we have a collection of scripts that look like they are from 1987, but that depend on Moose. Excellent!
(Actually, this inspired me to read the source code for Net::Twitter to see if it was using MooseX::Traits. Turns out they just copy-pasted from an older version of MX::Traits to get their traits functionality. Weird!)
- holdenk 15y agoSorry the perl code is so poor, it was a post-clubbing quick-hack type project. I'll clean it up when I have some free time again :)
- deleted 15y ago[deleted]
- draegtun 15y agoYou may find the following CPAN modules helpful when you do your refactoring: * Net::GitHub - http://p3rl.org/Net::GitHub http://p3rl.org/Net::GitHub * Pithub - http://p3rl.org/Pithub http://p3rl.org/Pithub
- holdenk 15y agoOh excellent. I only looked at Net::GitHub initially, but Pithub looks more interesting.
- rat 15y agoI thought using moose turned on warnings+strict(at least its claimed here http://stackoverflow.com/questions/6050031/why-are-use-warnings-use-strict-not-default-in-perl/6050340#6050340 http://stackoverflow.com/questions/6050031/why-are-use-warni...)
- draegtun 15y agoIt does. However warnings+strict are lexical so it will only apply to the module or scope where use Moose is put.
- glenjamin 15y ago> Accept when I use the wrong word. I can't tell... was that intentional?