7 ms·

A bot fixes spelling mistakes in github readme files

48 points by holdenk 15y ago

jrockway 15y ago
Interesting idea, although it would be nice if Github optionally fixed spelling mistakes for you. Pull requests just for spelling errors have got to be annoying. (I just run flyspell in Emacs, so I never make spelling mistakes. Accept when I use the wrong word.) The code is also pretty interesting. It's old-style Perl with indirect method calls, bareword filehandles, no "use strict", and so on... but then it uses modules that use Moose and MooseX::Traits. So we have a collection of scripts that look like they are from 1987, but that depend on Moose. Excellent! (Actually, this inspired me to read the source code for Net::Twitter to see if it was using MooseX::Traits. Turns out they just copy-pasted from an older version of MX::Traits to get their traits functionality. Weird!)
- holdenk 15y ago
  Sorry the perl code is so poor, it was a post-clubbing quick-hack type project. I'll clean it up when I have some free time again :)
  - deleted 15y ago
    [deleted]
  - draegtun 15y ago
    You may find the following CPAN modules helpful when you do your refactoring: * Net::GitHub - http://p3rl.org/Net::GitHub http://p3rl.org/Net::GitHub * Pithub - http://p3rl.org/Pithub http://p3rl.org/Pithub
    - holdenk 15y ago
      Oh excellent. I only looked at Net::GitHub initially, but Pithub looks more interesting.
- rat 15y ago
  I thought using moose turned on warnings+strict(at least its claimed here http://stackoverflow.com/questions/6050031/why-are-use-warnings-use-strict-not-default-in-perl/6050340#6050340 http://stackoverflow.com/questions/6050031/why-are-use-warni...)
  - draegtun 15y ago
    It does. However warnings+strict are lexical so it will only apply to the module or scope where use Moose is put.
- glenjamin 15y ago
  > Accept when I use the wrong word. I can't tell... was that intentional?
bandushrew 15y ago
Man, what a fantastic idea. Mildly interesting at the moment, but start running a static analyzer bot over everything, and its golden. should probably be an opt-in service, but WOW it would rock.
cdcarter 15y ago
I can't wait until I get a pull request trying to fix the spelling of my project name.
- Macha 15y ago
  Or for "fixes" like colour/color or centre/center.
bigiain 15y ago
Is anyone else as amused as I am by the juxtaposition of "I was at jwz's club" immediately followed by "perl and regexes seemed like a good idea"? (now he's got _two_ problems...)
6ren 15y ago
So git becomes the presentation component of a spellchecker - a novel and interesting re-architecture. You could do similar with peep-hole optimizations, bizarre bots that transform iteration to recursion (and vice versa), transforms to immutability, factoring-out common code, adding automatically constructed test cases ... I wonder what else. It would be like helpful spam. EDIT or clippy "It looks like you're writing a loop. Would you like help?" Actually, this could be a channel for code analysis as a service. You subscribe (for fee or free), it's all hosted and updated remotely and git-based (github public/private, or self-hosted).
Mizza 15y ago
I've been working on something like this recently, but I guess this guy beat me to the punch. Here's my nearly-done rainy day code: https://github.com/Miserlou/WhitespaceBot https://github.com/Miserlou/WhitespaceBot (Python) I'd like to add some security fixing stuff too. There's plenty that can be done here! Bots are the secret reason why Wikipedia actually works - there's no reason why we can't have the same benefits in open source software.
- holdenk 15y ago
  Your whitespace bot looks nifty :) Will you post the results when you start running it?

48 points by holdenk 15y ago

Interesting idea, although it would be nice if Github optionally fixed spelling mistakes for you. Pull requests just for spelling errors have got to be annoying. (I just run flyspell in Emacs, so I never make spelling mistakes. Accept when I use the wrong word.) The code is also pretty interesting. It's old-style Perl with indirect method calls, bareword filehandles, no "use strict", and so on... but then it uses modules that use Moose and MooseX::Traits. So we have a collection of scripts that look like they are from 1987, but that depend on Moose. Excellent! (Actually, this inspired me to read the source code for Net::Twitter to see if it was using MooseX::Traits. Turns out they just copy-pasted from an older version of MX::Traits to get their traits functionality. Weird!)

holdenk 15y ago
Sorry the perl code is so poor, it was a post-clubbing quick-hack type project. I'll clean it up when I have some free time again :)
- deleted 15y ago
  [deleted]
- draegtun 15y ago
  You may find the following CPAN modules helpful when you do your refactoring: * Net::GitHub - http://p3rl.org/Net::GitHub http://p3rl.org/Net::GitHub * Pithub - http://p3rl.org/Pithub http://p3rl.org/Pithub
  - holdenk 15y ago
    Oh excellent. I only looked at Net::GitHub initially, but Pithub looks more interesting.
rat 15y ago
I thought using moose turned on warnings+strict(at least its claimed here http://stackoverflow.com/questions/6050031/why-are-use-warnings-use-strict-not-default-in-perl/6050340#6050340 http://stackoverflow.com/questions/6050031/why-are-use-warni...)
- draegtun 15y ago
  It does. However warnings+strict are lexical so it will only apply to the module or scope where use Moose is put.
glenjamin 15y ago
> Accept when I use the wrong word. I can't tell... was that intentional?

bandushrew 15y ago

Man, what a fantastic idea. Mildly interesting at the moment, but start running a static analyzer bot over everything, and its golden. should probably be an opt-in service, but WOW it would rock.

cdcarter 15y ago

I can't wait until I get a pull request trying to fix the spelling of my project name.

Macha 15y ago
Or for "fixes" like colour/color or centre/center.

bigiain 15y ago

Is anyone else as amused as I am by the juxtaposition of "I was at jwz's club" immediately followed by "perl and regexes seemed like a good idea"? (now he's got _two_ problems...)

6ren 15y ago

So git becomes the presentation component of a spellchecker - a novel and interesting re-architecture. You could do similar with peep-hole optimizations, bizarre bots that transform iteration to recursion (and vice versa), transforms to immutability, factoring-out common code, adding automatically constructed test cases ... I wonder what else. It would be like helpful spam. EDIT or clippy "It looks like you're writing a loop. Would you like help?" Actually, this could be a channel for code analysis as a service. You subscribe (for fee or free), it's all hosted and updated remotely and git-based (github public/private, or self-hosted).

Mizza 15y ago

I've been working on something like this recently, but I guess this guy beat me to the punch. Here's my nearly-done rainy day code: https://github.com/Miserlou/WhitespaceBot https://github.com/Miserlou/WhitespaceBot (Python) I'd like to add some security fixing stuff too. There's plenty that can be done here! Bots are the secret reason why Wikipedia actually works - there's no reason why we can't have the same benefits in open source software.

holdenk 15y ago
Your whitespace bot looks nifty :) Will you post the results when you start running it?