3 ms·
Well they could have said 'Most PRs are bug ridden garbage' - stronger than I would use but fair enough. But no, it's a comment on the characteristics of peopl
by klelatti 5y ago
Well they could have said 'Most PRs are bug ridden garbage' - stronger than I would use but fair enough.
But no, it's a comment on the characteristics of people contributing to projects.
It's saying that they are not capable of making a quality contribution.
- asimpletune 5y ago> It's saying that they are not capable of making a quality contribution. But isn't that true? At least not right away, which is why the code gets reviewed. I'm pretty sure everyone writes bug ridden garbage, unless they're not already intimately familiar with the codebase already.
- entropicdrifter 5y agoIt's saying they are not capable of making a quality contribution without criticism/review. Your reply here is some serious pedantry, you're essentially arguing that the output of most programmers is totally disconnected from the abilities of most programmers. Really, what other relevant external indicators of the abilities of a given programmer does anyone have access to besides the code they output?
- klelatti 5y ago1. Your PR is bug ridden garbage. 2. You don't have the patience, skills or experience to write anything other than bug ridden garbage. Not pedantry at all so see a big distinction between these two statements. In fact almost a textbook study of how to / how not to give feedback.
- OJFord 5y agoThose are both hypothetical statements directed at an author, which nobody here has done or advocated doing. And regarding 2, the original was a general statement about the existence and prevalence of (low) skill; not an indictment against any specific author of 'garbage' who may (or may not) be capable of better.