3 ms·
> if I see it as worth changing I'll do it myself after the merge. 100% agree! Someone unfamiliar with the code base takes the time to make a change that impro
by brabel 5y ago
> if I see it as worth changing I'll do it myself after the merge.
100% agree! Someone unfamiliar with the code base takes the time to make a change that improves something, for free and without asking for anything in return... I always try to take it as it is, only asking for changes that are really necessary to avoid bugs or serious problems, then I normally go and do a post-merge cleanup to try to keep things organized in the way I want (which is hard for outsiders to do themselves).
> There's too many ways to do things.
Exactly! That's why Rust PR reviews are always dangerously close to descending into nit-pick shit shows - there's ALWAYS a 0.1% nicer way to write something, you can always change it to make it 2% more efficient, or to avoid allocating as much memory, or avoid using explicit lifetimes, or avoid dynamic dispatch.... the list goes on.