3 ms·
A PR is a gift and a burden. A gift of someone else's effort to contribute and push something forward. A burden because once received, future maintainance of
by buro9 5y ago
A PR is a gift and a burden.
A gift of someone else's effort to contribute and push something forward.
A burden because once received, future maintainance of the gift is really on the one who received the gift.
It may as well be the gift of a kitten... you now have to look after the kitten for the next 12-15 years. Is it socialised? House-trained? How much effort does this take when there are also gifts of other animals stacked up behind this one?
I don't think it's constructive to paint the approver as gatekeeping, or perfectionist. What does that achieve? Surely it's better to meet halfway on the gift exchange, thank you for the PR but it does need to be house-trained and socialised, etc.
- gojomo 5y ago"Open source: the gift that keeps on taking." (Earliest use I can find here – https://twitter.com/devbisme/status/1017520086096207874 https://twitter.com/devbisme/status/1017520086096207874 – but perhaps goes back much further.)
- deleted 5y ago[deleted]
- deleted 5y ago[deleted]
- PragmaticPulp 5y agoThe problem is when contributors view their contributions as a gift rather than a starting point for collaboration. Rejecting a gift is quite a rude gesture. Rejection a PR contribution until it receives further iteration after some thoughtful feedback is anything but a rude gesture. I think this mindset that open source maintainers are obligated to accept PRs as gifts is the source of much of this frustration. The PR should be a starting point for further discussion, iteration, and collaboration, not a one-way gift that places a burden on the maintainer to satisfy the wants of the contributor.