3 ms·
Part of the problem in my experience is expecting programmers to work solo, only interacting with other programmers during standup meetings or when they are ask
by nerdponx 5y ago
Part of the problem in my experience is expecting programmers to work solo, only interacting with other programmers during standup meetings or when they are asking for help.
I'm not sure how I feel specifically about pair programming, but I do think that even "local" code changes should be accompanied by at least some architectural discussion with other developers who work on that part of the system. Usually the discussion can be as simple as "does XYZ design seem like a good idea? yeah, go ahead". But in my opinion it's important to encourage, incorporate, and expect collaboration as part of the basic workflow.
Perhaps this is also part of the problem with code reviews. Reviewing code is kind of difficult. But it's a lot easier if you've already discussed the design beforehand with the person whose code you're reviewing, so at least you already know why they did what they did, and you aren't going to be surprised, and then have to spend time writing up your disagreement and entering a back-and-forth process that sucks up time.
- dahart 5y agoPair programming is really hard to make work well, but when it does, I’ve rarely had more fun coding. I’ve had a couple of amazing experiences with pairing, and it’s made me crave repeating the experience. Unfortunately, it hasn’t worked most of the time. But I think you’re right - I think what you’re saying is code reviews should start before the change is being proposed for commit - it should be an architecturally collaborative process at some level. Code should be guided by reviewers in a positive feedback loop rather than left to critique at the last second. Reviewing code well is difficult, and also important to take seriously.