4 ms·
Right but your diff for #94 will include all of the changes in #80 as well, because it's being compared to the main branch. When you do this a few layers up you
by stevewodil 5y ago
Right but your diff for #94 will include all of the changes in #80 as well, because it's being compared to the main branch. When you do this a few layers up your diff is suddenly massive and hard to navigate for review.
Also if you need to change anything about #80 you have to rebase #94. Which also means the same for any other branches that you or someone else created on top of #94 that depended on #80 landing
- jimmaswell 5y agoMake feature branch off main, push, make a PR, checkout main again, make a different feature branch with a different PR, repeat. Why would I continue using the other feature branch for the 2nd?
- stevewodil 5y agoBecause if the second feature requires the code changes from the first PR you can't do that... If your team doesn't have a use for stacked diffs that's fine. Teams of one also don't use pull requests and might not understand why we need those.
- jimmaswell 5y agoIt's very rarely come up for me that multiple open issues depend on each other. Maybe it happens more in some codebases than others.