4 ms·
> Waiting for more than 20-30 minutes for a review is ridiculous Does your entire team just sit around doing nothing waiting to review your code? That timeline
by richwater 5y ago
> Waiting for more than 20-30 minutes for a review is ridiculous
Does your entire team just sit around doing nothing waiting to review your code? That timeline is asinine.
- mchusma 5y agoI don't know that it is optimal, but our team generally batches PRs once per day, to avoid interrupting them. So typically it's going to take about a half day for a review. As different people end their day at different times. Exceptions of course, but this seems close to optimal to me (from the reviewers perspective).
- lmm 5y agoIf reviewing is the bottleneck for your team then having some slack where people sit around waiting to do reviews may well be the most efficient use of time (e.g. having a reviewer rotation where each week one person is a designated reviewer).