3 ms·
I understand what a feature branch is. I don't understand why I'd need a branch to add an emoji. I assumed that a 'reactions' branch might be a branch that add
by secondcoming 5y ago
I understand what a feature branch is. I don't understand why I'd need a branch to add an emoji.
I assumed that a 'reactions' branch might be a branch that addresses issues in the original PR, but even if it was, why would I need a new branch for that?
- tomasreimers 5y agoProbably because you're trying to break up your changes. Two good blog posts that talk about this workflow are: https://jg.gg/2018/09/29/stacked-diffs-versus-pull-requests/ https://jg.gg/2018/09/29/stacked-diffs-versus-pull-requests/ and https://kurtisnusbaum.medium.com/stacked-diffs-keeping-phabricator-diffs-small-d9964f4dcfa6 https://kurtisnusbaum.medium.com/stacked-diffs-keeping-phabr...
- secondcoming 5y agoThose were useful, thanks!
- joshuamorton 5y agoSince I don't use git much these days, I'm going to speak in generalities. I would guess the assumption is that you can't have reactions without comments. So comments v1 is "comments" and v2 is "reactions". They need to be different PRs, so I guess that's what leads to different branches. But they can be reviewed independently, you just have to merge one before the other.
- Jensson 5y agoThere are two features you want to add, called "comments" and "reactions". Those aren't PR lingo, they could be named "Feature X" and "Feature Y".