4 ms·
>> We could remove all duplication by grouping the code like this instead: 1. It seems to me that you refactored the code in the wrong dimension. I would have
by hackbinary 5y ago
>> We could remove all duplication by grouping the code like this instead:
1. It seems to me that you refactored the code in the wrong dimension. I would have abstracted out a template shape object.
2. Are you not using a pull request/peer review process to accept changes into the prod branch?
3. I don't think you quite arrived at the right conclusion. While you conceed that your original conclusion was incorrect, I do think your original criticism has merit, and while your solution may provide a different set of problems, that doesn't mean that a different solution based upon the collaboration between yourself and your colleague might have been yet even better.