4 ms·
> If you worked for me and randomly changed code that you did not like, I would fire you. From one extreme to the other? People make mistakes, educate them ins
by emerongi 5y ago
> If you worked for me and randomly changed code that you did not like, I would fire you.
From one extreme to the other? People make mistakes, educate them instead of brutally punishing them. Talk it through - isn't this exactly the mistake that was made by the developer (they didn't talk to their peers)? If they do not respond to feedback, that can eventually lead to a firing.
- uberman 5y agoOf course I would talk to a junior dev right out of college and tell them these kind of "drive by" refactorings were counter productive and dangerously susceptible to the introduction of lack of context bugs... ONCE. The hiring process is too expensive and time consuming to punt on a junior dev or intern for such a transgression. However, if the behavior persisted then yes, I would fire them. If anyone sees code that they hate they are free to submit an issue and I will be happy to review it and prioritize it with the other work to be done. If they hate code that smells so much that they want to volunteer their time to refactor it, then they can participate in code reviews for me instead.