4 ms·
the review should also be reviewing the tests, and you should really have a test if you have a standard.
by flatiron 5y ago
the review should also be reviewing the tests, and you should really have a test if you have a standard.
- tablespoon 5y ago> the review should also be reviewing the tests, and you should really have a test if you have a standard. Codes reviews and unit tests aren't a substitute for QA or acceptance testing. It's great when code reviews do catch stuff like this, but that's not going to catch everything. To me this bug points to deficiencies in another part of the process.
- mypalmike 5y agoOne would have to know about this failure mode to write a test for it. Would you think to write this particular test?
- flatiron 5y agoI know nothing about this encoding but I would think each implementable feature of the standard should have some tests that you can implement. Maybe some sample data and then process it’s encoded counter part. I bet I am trivializing it but I would hope they are thinking twice about shoring up their process.