4 ms·
Hopefully I didn't come off aggressively, I was just trying to give you some feedback. In terms of hyperapp, that is as much compiling as `document.createEleme
by mrozbarry 5y ago
Hopefully I didn't come off aggressively, I was just trying to give you some feedback.
In terms of hyperapp, that is as much compiling as `document.createElement("a")`, which is what your library does, too.
I'm not saying write redundant tests. Tests are more than just one person's psychological comfort. Another great example is if you are accepting PRs into a larger codebase, having tests means you know other people aren't breaking previously working parts of your app. Tests can also work as documentation, since a test describes how pieces of your app should work.
I'm confused why you think any of my suggestions imply that you should make your library heavy/larger/unmanageable.
- ClassicOldSong 5y agoI mixed hyperapp with hpyerscript.. My bad In terms of "heavy", it's actually a problem with node's package management. Once I include test frameworks as dev dependencies, there's a high chance of installing my package will get the test framework together with it's whole bunch of dependencies installed as well - very unnecessary and time consuming.
- mrozbarry 5y agoNo problem, the JS ecosystem is so full that there is a lot of naming overlap. Nothing should be stopping you from just making a test file, you don't _have_ to use a framework. NodeJS even comes bundled with https://nodejs.org/api/assert.html https://nodejs.org/api/assert.html .