3 ms·

1. This was just a POC, and there's yet no document. Testing may be added later but for there's only 400 lines of code, it could hardly go wrong. The demo itsel

1. This was just a POC, and there's yet no document. Testing may be added later but for there's only 400 lines of code, it could hardly go wrong. The demo itself acts as a proof of correctness as well. 2. Hyperapp actually does have some sort of compiling (at least parsing a string for a tag) 3. There're far more advanced usages that you may not aware of, so build function has no need to care about whether it's in test mode. More usage demos may come later. 4. I'm actually not a fan of writing redundant tests. IMO tests are more of a psychological comfort for users to see rather than a practical proof of robustness. Though it could gaurantee some sort of correctness, it won't cover how users want to use it. It's a waste of time to write a whole bunch of tests and run them every now and then. 5. I don't want to make this project "heavy", and I hate "heavy" projects.

mrozbarry 5y ago
Hopefully I didn't come off aggressively, I was just trying to give you some feedback. In terms of hyperapp, that is as much compiling as `document.createElement("a")`, which is what your library does, too. I'm not saying write redundant tests. Tests are more than just one person's psychological comfort. Another great example is if you are accepting PRs into a larger codebase, having tests means you know other people aren't breaking previously working parts of your app. Tests can also work as documentation, since a test describes how pieces of your app should work. I'm confused why you think any of my suggestions imply that you should make your library heavy/larger/unmanageable.
- ClassicOldSong 5y ago
  I mixed hyperapp with hpyerscript.. My bad In terms of "heavy", it's actually a problem with node's package management. Once I include test frameworks as dev dependencies, there's a high chance of installing my package will get the test framework together with it's whole bunch of dependencies installed as well - very unnecessary and time consuming.
  - mrozbarry 5y ago
    No problem, the JS ecosystem is so full that there is a lot of naming overlap. Nothing should be stopping you from just making a test file, you don't _have_ to use a framework. NodeJS even comes bundled with https://nodejs.org/api/assert.html https://nodejs.org/api/assert.html .

mrozbarry 5y ago

Hopefully I didn't come off aggressively, I was just trying to give you some feedback. In terms of hyperapp, that is as much compiling as `document.createElement("a")`, which is what your library does, too. I'm not saying write redundant tests. Tests are more than just one person's psychological comfort. Another great example is if you are accepting PRs into a larger codebase, having tests means you know other people aren't breaking previously working parts of your app. Tests can also work as documentation, since a test describes how pieces of your app should work. I'm confused why you think any of my suggestions imply that you should make your library heavy/larger/unmanageable.

ClassicOldSong 5y ago
I mixed hyperapp with hpyerscript.. My bad In terms of "heavy", it's actually a problem with node's package management. Once I include test frameworks as dev dependencies, there's a high chance of installing my package will get the test framework together with it's whole bunch of dependencies installed as well - very unnecessary and time consuming.
- mrozbarry 5y ago
  No problem, the JS ecosystem is so full that there is a lot of naming overlap. Nothing should be stopping you from just making a test file, you don't _have_ to use a framework. NodeJS even comes bundled with https://nodejs.org/api/assert.html https://nodejs.org/api/assert.html .