4 ms·
Out of curiosity: would the 1995 JS code pass any modern code review?
by rmbyrro 5y ago
Out of curiosity: would the 1995 JS code pass any modern code review?
- casion 5y agoJS from 2003 passed code review for me a few months ago... so, yes... maybe.
- deleted 5y ago[deleted]
- np_tedious 5y agoProbably depends what it's doing. If it's interacting with HTML and manipulating the DOM then probably not
- helsontaveras18 5y agoHow do modern frameworks display content? Must be interacting with HTML and manipulating the DOM in some way.
- lostcolony 5y agoIt's not whether they do, it's how they do. For instance, in 2003 there was no such thing as a mobile phone; passing code review today is probably going to entail either being responsive, or directing to a mobile version when accessed from a mobile device.
- kgwgk 5y agohttps://news.microsoft.com/2001/02/19/microsoft-mobile-explorer-3-0-provides-tomorrows-wap-2-0-functionality-today/ https://news.microsoft.com/2001/02/19/microsoft-mobile-explo...
- lostcolony 5y agoOkay, I will clarify my hyperbole in the face of the pedantic - mobile phones did not provide ubiquitous, standardized approaches to browsing the web, such that UX guidelines for the web did not include them; media queries and such did not exist except as drafts, etc etc.
- deleted 5y ago[deleted]
- mr_toad 5y agoI’d imagine it would get pinged for using var instead of let or const. And depending on who’s doing the review they might not like ‘new’.
- FpUser 5y ago>"I’d imagine it would get pinged for using var instead of let or const." This single thing in isolation should never cast code as good or bad.