3 ms·

I find that use of goto quite confusing, and would prefer a comment in such a case: switch( machineState ){ case ALPHA: ... break;

• JadeNB 15y ago
  That's particular to situations that can be solved by fallthrough. What about switch ( machineState ) { case ALPHA: ... alpha prep ... goto gamma case BETA: ... beta prep ... goto gamma case GAMMA: gamma: ... } ? (EDIT: Not to say that you shouldn't still comment, of course.)
  • nitrogen 15y ago
    In this case it might be clearer to just run the switch again after ALPHA and BETA with GAMMA as the machineState, and if necessary, have logic in GAMMA for switching machineState back to ALPHA or BETA. It also might be clearer to move GAMMA outside the switch block entirely: int shouldGamma = 0; switch ( machineState ) { case ALPHA: ... alpha prep ... shouldGamma = 1; break; case BETA: ... beta prep ... shouldGamma = 1; break; case GAMMA: shouldGamma = 1; break; } if(shouldGamma) { // GAMMA stuff here } The shouldGamma flag would be unnecessary if all possible values for machineState should still run the code in GAMMA.