3 ms·
> if an update is not (yet) possible, DjVu format file uploads can be blocked to avert this vulnerability Note that the issue was enabled by GitLab not verify
by magicalhippo 5y ago
> if an update is not (yet) possible, DjVu format file uploads can be blocked to avert this vulnerability
Note that the issue was enabled by GitLab not verify the file format, ie that a .jpg is a JPEG and not a DjVu file for example, before handing it over to ExifTool.
So a simple extension/mime check won't cut it.
- morelisp 5y agoNor should they rely on their verification of the file format for anything other than a temporary mitigation of this specific bug! If the ExifToof / DjVu tooling itself isn't secured or sandboxed, this would be a future exploit waiting to happen.
- magicalhippo 5y agoAbsolutely. To be honest I was a bit shocked they used an ExifTool binary that had anything but JPEG/TIFF support compiled in.