2 ms·
If you were really reviewing that code, Rust has algebraic data types, and access level should be an Enum, not a String. But it's their example. The problem is
by nonameiguess 5y ago
If you were really reviewing that code, Rust has algebraic data types, and access level should be an Enum, not a String.
But it's their example. The problem isn't with homoglyphs, though. It's with bidi control characters, which are invisible to a human but not to the compiler, which is how generated code can end up semantically different from source code, which is the actual problem here. What you see in code review would be the first line, even though that isn't actually what is in the source, because an editor that is bidi-aware would show it that way.
- steveklabnik 5y ago> But it's their example It's the example that the researchers provided to us, to be clear about it.
- lol768 5y ago> It's with bidi control characters Sure.. in the original HN submission. I was referring to Rust's built-in homoglyph detection though, which is what the parent comment (and its parent) was about.