4 ms·

Are suggesting that code review is a net negative or that having a visual interface for reviewing a patch set brings out worse in people than emailing around pa

Are suggesting that code review is a net negative or that having a visual interface for reviewing a patch set brings out worse in people than emailing around patchsets? Code-bases, especially large ones “Must Be Attended To” and reviews should be impersonal. A good review is inherently inspection and critiquing code, not the author and can present many good learning opportunities for both sides of it.

pydry 5y ago
>Are suggesting that code review is a net negative Good god no. I'm, ironically enough, suggesting that misinterpretation of textual content is a bit of a problem :) >reviews should be impersonal. A good review is inherently inspection and critiquing code, not the author I can remember hundreds of times I've seen textual code reviews that were "just critiquing code" that were interpreted as a critique of the author. It's particularly a problem when coders with slightly less social awareness than others write comments and don't pause to think how they might be interpreted. The example I gave in the comment above is just one of these.