25 ms·
Well, I think it is because so many people don't use version control in the intended way nowadays. I always review my changes before committing / pushing, but I
by Koffiepoeder 5y ago
Well, I think it is because so many people don't use version control in the intended way nowadays. I always review my changes before committing / pushing, but I have the impression many developers nowadays just stage, commit and push, as if VC is some sort of simple storage mechanism. I have talked to numerous people over the past few years to ask them to disable auto-formatting and/or to check their changes before pushing, but alas not always with the intended result. In the end I decided to push for using auto-formatting commit hooks in some projects (even though I dislike it on my own code).
An unfortunate observation: the majority of these projects were bloated, frontend javascript applications. In complicated backend applications I seem to encounter a higher SNR, and thus no necessity for commit-hooks.
- hsn915 5y agoUltimately version control is about easily merging changes from people working on different machines. Being able to "review" changes as clean set of patches is not essential. The mindset of "we must review every change before it goes in" is not based in reality anyway. Have you ever seen a system of code reviews produce useful benefits that would not be there without it? You can always review already-committed code and discuss it within the team. It does not need to happen at commit time.