4 ms·
> People will ignore the IDE error messages. Then they get caught in code review at least in any team I work. No way I accept any unnecessary "disable lint" s
by skinkestek 5y ago
> People will ignore the IDE error messages.
Then they get caught in code review at least in any team I work.
No way I accept any unnecessary "disable lint" statement in a PR.
Also (of course, since it is default) the CI build system breaks if they commit and push without ignores, so no, trying to slide it past me doesn't work either.
- johnnypangs 5y agoIt's not linting, it's typechecking which is slightly different. Linting won't catch type errors. All I'm recommending is to add a typecheck to the CI system so no one sneaks in a broken type (I couldn't recognize a broken type in a PR personally).