3 ms·
I'm in a similar position in a non FANG company. I almost made the similar mistake of telling people it was a bad codebase. I did inform my manager though. My m
by 8589934591 5y ago
I'm in a similar position in a non FANG company. I almost made the similar mistake of telling people it was a bad codebase. I did inform my manager though. My manager and I are new hires in the company so it didn't seem like an issue to be vocal to him.
I have seen my manager do the exact same thing as you did. He went to the architect behind the codebase and started complaining and raising hell. Since my manager is on better terms with the higher ups things are swaying towards his end else it'd be a fiasco.
My suggestion is that when you encounter such code bases either go with it or do some small refactors in the smallest of code and say "hey I feel this is a better way to do it. Can you review this?". I have felt this has usually worked for me. Additionally, instead of stating it outright that the code is bad, ask them to explain the code and the reasons behind it. If you are still on good terms and they don't see you as a threat, then you can ask questions and maybe suggest alternatives with a working prototype. This way you still come off as an "honest" person who's trying to do something good. This works in your favor when looked at by your manager and upper management. This is apart from the features that you're tasked to push.
Hope that helps.
- throwaway_fred 5y ago>Hope that helps. It does, thanks. I didn't say directly that their code is bad. But asking is futile, communication is bad. They dont want to make it a prio and 8 hour time diff makes it hard. I spent too many nights up to have video calls about it. But you're advice aligns with other people here. Regardless of he sate, I should be help drive it with refactors and just deal with it indeed.