4 ms·
https://github.com/reactiveui/splat/pull/778 https://github.com/reactiveui/splat/pull/778
by llacb47 5y ago
https://github.com/reactiveui/splat/pull/778 https://github.com/reactiveui/splat/pull/778
- SandB0x 5y agoThe diff https://github.com/reactiveui/splat/pull/778/files https://github.com/reactiveui/splat/pull/778/files
- bingohbangoh 5y agoWow. That’s very brazen to force a PR in like that. The apology made it sound like a small change that didn’t follow protocol. I didn’t realize it got called out as it happened and she pushed it through anyway.
- booleandilemma 5y agoYeah I cringed when I saw how she kept re-opening the PR the maintainer had closed. No respect.
- oaiey 5y agoWhat especially strange is, when you are one of multiple maintainers ... how the hack you are not communicating with them. Multiple maintainers = they need to have shared principles on the projects = they need to talk. Ignoring this, is the strangest thing I have seen in this PR ... and a clear indicator, that this is not only about this project. This was a nuclear action by the .NET Foundation.
- tonymet 5y agoThat extra whitespace is horrible
- dequor 5y agoThere's no extra whitespace, it's just in the wrong place
- snapdaddy 5y agoYeah, as I thought - If I were the maintainer of that project I would have had no issue with her merging that. But I also understand why PRs exist and process, so I would have said, 'yeah, cool, just don't do it again. Nothing to see here, move along.'
- katbyte 5y agoone thing to just merge it, but another entirely to reopen it twice disregarding what the maintainer has asked of you before forcing it. At the very least disrespectful and arrogant.
- pcj-github 5y agoI just don't get why not drop a brief explanation on the validity of the PR? She could have so easily avoided this. Active maintainers are right to be pissed.