3 ms·
This is hardly a significant issue. Many projects that have -Werror on by default support a --disable-werror configure flag. Your project can do the same. As f
by ludocode 5y ago
This is hardly a significant issue. Many projects that have -Werror on by default support a --disable-werror configure flag. Your project can do the same.
As for compiler upgrades breaking things, everyone should be on the same compiler version to begin with. When a new Visual Studio version comes out you don't just let everyone upgrade right away, right? Someone installs it first and fixes up whatever issues arise with the new build tools. Then, at an appropriate point in the release cycle, they give the OK for everyone else to upgrade. Everyone upgrades at once including the CI nodes.
Why would GCC and Clang be any different? A serious project should have developers using a fixed version of GCC and other tools. Of course this doesn't help the random open source contributors who just use their system GCC but that's what --disable-werror is for.
- saagarjha 5y agoPerhaps these projects should --enable-werror instead and use it internally, instead of pushing it to everyone else who is obviously not going to use the one blessed GCC that you have selected privately?
- jeltz 5y agoThis simply does not work for open source projects where you cannot control which compiler versions are used by people. Almost every time there is a new version of gcc or clang there will be a bunch of new warnings in any major code base. Additionally -Werror makes it harder to run git bisect.
- deleted 5y ago[deleted]