4 ms·
I never said it was easy, it does require the team to have some discipline about it, but it doesn't sweep the issue that the warning was about under the rug, hi
by daemin 5y ago
I never said it was easy, it does require the team to have some discipline about it, but it doesn't sweep the issue that the warning was about under the rug, hidden from view.
If you have a lot of warnings then you have a lot of issues with the code. Would you rather have them visible or disabled?
- outsomnia 5y agoThey are not 'visible' if you just let them scroll by. If there are individual warnings that have no meaning, turn them off. Everything else, is help from the compiler, which is your only friend. Ignoring even one of those should not be tolerated at all. They must be analyzed and the code improved to remove them. And you enforce your team following that policy with -Werror.
- daemin 5y agoYeah, but push comes to shove during shipping, people leave, and the pragmas remain in the code in various places. At least if they are scrolling by then people can get fed up with that and take some initiative to fix those warnings. Or the new people joining your studio can come in and try to fix them. It's much more difficult to get people to fix pragmas scattered throughout the code. Which ones were legit, which ones were put in at the last moment out of frustration, which ones were put in temporarily years ago? I think a softer approach works better since people won't be so quick to work around the compiler by disabling the warnings.