3 ms·
I worked in a place where it was not like that. And it was dysfunctional. Instead, people nitpicked to death and tried to one-up each other with findings. Ther
by watwut 5y ago
I worked in a place where it was not like that. And it was dysfunctional.
Instead, people nitpicked to death and tried to one-up each other with findings. There are loooong arguments over completely irrelevant details. There were multiple rounds of review, sometimes changing the code there and back again. People attempted to code into review comments. And the expectations changed every week, there was no stable standard.
It was more about taking control and showing yourself more caring by finding increasingly insignificant things and then insisting on them.
- legerdemain 5y agoCode reviews are a smell.
- TameAntelope 5y agoNot wanting someone to review your code is a bigger smell, IMO.
- pferde 5y ago"Only children and fools speak in absolutes." -someone, somewhere, I don't remember. Code reviews can be a good thing or bad thing, depending on what each party brings in and intends to get out of them. Painting them unequivocally as bad is rather silly.
- regularfry 5y agoCode reviews are one of the very few software practices that there's good evidence in favour of. This is not necessarily in conflict with your statement.
- ryohkyo 5y agoOops, and I thought civil engineering was messy. Time to switch back to civil engineering, at least it is, more civil than this.