4 ms·

basically means a PR is when the feature is done. you're not asking for code ideas, you're proposing a finished change.

• reidjs 5y ago
  Sometimes I will use a draft PR if I need to show some intermediate code, but I mostly agree. If you put up a PR that means you’re proposing this code is solid and should go into production.
  • Chemaclass 5y ago
    Totally. This is a relatively new concept since a year or so, but there are still people who doesn't use them. But I think a Draft-PR is a great opportunity to show the progress of your changes even if it's not finished yet.
    • brigandish 5y ago
      What are the benefits of a draft PR over publishing a feature branch that others can access?
      • jlokier 5y ago
        Assuming you're using GitHub: a draft PR has a comments thread, which you might choose to keep after merging; it can have linked issues (that close if the PR is merged); the draft PR is organised in the list of PRs so it has higher visibility than a branch (some projects have hundreds of branches but few draft PRs) and a more clearly presented one-line description, and you can promote it to a regular PR while keeping the comment history. Overall theme: With a feature branch, you'll need to announce and discuss it somewhere else. With a draft PR, those are features attached to the PR.
• Chemaclass 5y ago
  Yes, that was what I meant. Thanks.