3 ms·
The problem is that when I upload a new patch set for a change that already exists, all the review comments I had on the previous patch set are "lost". Also fin
by exDM69 15y ago
The problem is that when I upload a new patch set for a change that already exists, all the review comments I had on the previous patch set are "lost". Also finding the differences between two patches in a change is difficult.
What I'd really want to do in this situation is to have a feature branch where I push another commit for review. The difference is clearly visible and I can get new review comments without losing the old ones. This works very well with Git and GitHub.
- dlsspy 15y agoThat's exactly how we use gerrit. The most recent change in our gerrit install is on its sixth revision: http://review.couchbase.org/8560 I pulled this one arbitrarily, it just happened to be the top. It's got a dependency and they change together. It works flawlessly and almost entirely transparently as long as you have a Change-Id (for which there's a simple hook to generate).