2 ms·
I know we're not golfing, but it pains me to see that repetition in the middle. Mightn't we write if (!validateURL(url)) { url = "http://" + url;
by JadeNB 5y ago
I know we're not golfing, but it pains me to see that repetition in the middle. Mightn't we write
if (!validateURL(url)) {
url = "http://" + url;
if (!validateURL(url)) {
url = null;
}
}
return url;
to snip a small probability of a bug?
- wolfgang42 5y agoI find that branchiness (and mutation of the variable) harder to follow. Personally, I’d just take “parse, don’t validate” to its logical conclusion and go for: const parseUrl = url => validateUrl(url) ? url : null; return parseUrl(url) || parseUrl('http://'+url) || null;