4 ms·
IMO the absolute worst is excessive criticism while missing a serious business logic or functionality bug. In my opinion the first priority of code review shou
by X6S1x6Okd1st 5y ago
IMO the absolute worst is excessive criticism while missing a serious business logic or functionality bug.
In my opinion the first priority of code review should be to prevent mistakes in the code at hand
- nine_zeros 5y ago> In my opinion the first priority of code review should be to prevent mistakes in the code at hand I disagree. The first priority of code review is WHAT problem is it trying to solve and does it actually solve the problem. If it's not even solving the problem correctly, pedantic nitpicks are inconsequential.
- X6S1x6Okd1st 5y agoOh yeah I agree, when I said mistakes in the code at hand I was considering a buisness logic bug/failure to 100% be in bound.