3 ms·
> excessive amount of criticism on working code Because it creates technical debt, that's why people get frustrated with shit code. They just aren't properly e
by dreyfan 5y ago
> excessive amount of criticism on working code
Because it creates technical debt, that's why people get frustrated with shit code. They just aren't properly equipped how to convey/teach/train/fix it without coming across like an asshole.
- phendrenad2 5y agoThat is exactly why many harshly critique code. But I've never found their versions to be any less full of tech-debt. Usually it comes down to personal style. "Oh Brenda hates if/else, better convert it to ternary before I submit it. But Oh No! Bob is reviewing it instead! He hates ternary and always wants if/else! I'm doomed..."
- Thiez 5y agoSounds like that team should define a style guide and stick to it. Either Brenda or Bob is going to be disappointed for a bit, but the code will be more consistent in the end.
- dreyfan 5y agoIf code reviews are centered around style the entire org is fucked.
- deleted 5y ago[deleted]
- dwaltrip 5y agoThis is why automatic code formatters such as Prettier -- are absolutely genius for teams. (It doesn't work for your particular example of ternary vs. if/else but the point still holds.)
- Rexxar 5y ago> Because it creates technical debt Does it ? Sometimes, the code reviewer has taken less time to analyze the problem and has not seen all problems a simpler solutions would bring.
- carlmr 5y agoThis is why it's better to phrase the review points as questions, e.g.: "Why is this done in this way, ? Wouldn't x be more efficient ?"