4 ms·
bad PRs shouldn't be allowed, but you don't have to be a smug a-hole while reviewing PRs. hell, that's a GREAT opportunity to get this "bad developer" under yo
by fernandotakai 5y ago
bad PRs shouldn't be allowed, but you don't have to be a smug a-hole while reviewing PRs.
hell, that's a GREAT opportunity to get this "bad developer" under your umbrella and start mentoring him to be a better developer.
- fayten 5y agoYup! I have been very fortunate to work with extremely kind and empathetic senior engineers in the past. They have done wonderful jobs at using the code review process to teach instead of tear anyone down. I am always shocked at how many programmers become so aggressive about development. It might be silly, but I think the xkcd comic Ten Thousand is a great mantra: https://xkcd.com/1053/ https://xkcd.com/1053/ Teaching people cool new ways to code should be fun, not an exercise in showing everyone the size of your ego.