4 ms·
90% of people are fine and code review has tons of benefits.. but the format is an enabler for 'that guy', as you're asking them for approval rather than runni
by refenestrator 5y ago
90% of people are fine and code review has tons of benefits.. but the format is an enabler for 'that guy', as you're asking them for approval rather than running it by them as an FYI.
I've seen a few different motivated hard workers get to hard work on demanding as many changes as possible whenever they are on a CR.
- dv_dt 5y agoThere is also the flip side too where a block of code might just have a lot of problems and I’m trying to evaluate if it’s too hard in a public forum to flag all of them at once. If possible I try to flag a couple and to sit down and offer to do a one on one for more.
- refenestrator 5y ago+1 to taking it offline when it's more than a couple minor style fixes.