3 ms·
Perhaps a better strategy for code reviews is "LGTM with nits". 1. Every change should go through code review 2. Changes should be small, to make them easier
by cyb_ 5y ago
Perhaps a better strategy for code reviews is "LGTM with nits".
1. Every change should go through code review
2. Changes should be small, to make them easier to review, less risky, and to promote continuous integration
3. Team should prioritize review latency
4. Reviewers should LGTM/approve if there are no major issues with the change, trusting the author to resolve any minor/nit comments
https://dev.chromium.org/developers/contributing-code/minimizing-review-lag-across-time-zones https://dev.chromium.org/developers/contributing-code/minimi...
- occz 5y agoI like that! I've done approved with suggestions for a long time, it strikes a good balance I think - and I've long been an advocate of fast reviews as a priority.