3 ms·
What I take from this approach is that you might want to leave an option for automatic merge/change application after CI green lighting. So a documentation chan
by choeger 5y ago
What I take from this approach is that you might want to leave an option for automatic merge/change application after CI green lighting. So a documentation change could be tagged as such and go live directly.
But do you really need a framework for that? Should not every developer be able to bypass the code review any time when necessary?
- jcon321 5y agoAllowing developers to merge directly into any mainline is a bad idea. Everyone makes mistakes here and there. I have senior developers STILL committing things they didn't intend to (that have been using git for years), and so a chance for someone to review it helps. But maybe they still make mistakes because they know someone else is going to look at it, I don't know.
- mmis1000 5y agoI disabled push on master for everyone (includes myself). There are just damn so many `forgot to create a branch and pushed directly on master` type accidents. A auto approved PR at least allows you to know who made the change at when. Push directly don't really preserve the information.